Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support P4.org In-band Network Telemetry (INT) #4230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jingfeihu
Copy link
Contributor

1.support INT MX/MD mode.
2.support INT over IPv4/IPv6+TCP/UDP/VXLAN/GRE/GENEVE.
3.add 28 testcases for INT.

@jingfeihu jingfeihu changed the title [INT] support P4.org INT layer Support P4.org In-band Network Telemetry (INT) Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #4230 (5b44983) into master (d71014a) will decrease coverage by 34.22%.
Report is 5 commits behind head on master.
The diff coverage is 62.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4230       +/-   ##
===========================================
- Coverage   81.77%   47.55%   -34.22%     
===========================================
  Files         331      325        -6     
  Lines       76721    71527     -5194     
===========================================
- Hits        62736    34016    -28720     
- Misses      13985    37511    +23526     
Files Coverage Δ
scapy/layers/inet.py 22.40% <20.00%> (-48.21%) ⬇️
scapy/contrib/int.py 82.35% <82.35%> (ø)
scapy/contrib/geneve.py 51.66% <40.00%> (-45.56%) ⬇️

... and 255 files with indirect coverage changes

1.support INT MX/MD mode.
2.support INT over IPv4/IPv6+TCP/UDP/VXLAN/GRE/GENEVE.
3.add 28 testcases for INT.
@jingfeihu jingfeihu marked this pull request as ready for review January 25, 2024 05:56
@@ -806,6 +806,15 @@ def mysummary(self):
else:
return self.sprintf("TCP %TCP.sport% > %TCP.dport% %TCP.flags%")

def guess_payload_class(self, payload):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its not a good idea to import your contrib layer in guess_payload_class of TCP. Can you maybe move this port to dispatch_hook?

@@ -862,6 +871,15 @@ def mysummary(self):
else:
return self.sprintf("UDP %UDP.sport% > %UDP.dport%")

def guess_payload_class(self, payload):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@polybassa
Copy link
Contributor

Thanks for your PR. Your code looks good so far, besides my to comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants