Feature/add-ptp-protocol #4640
Draft
Feature/add-ptp-protocol #4640
+252
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement PTP header structure based on IEEE 1588-2008 - Implement Sync message type class
gpotter2
reviewed
Jan 12, 2025
gpotter2
reviewed
Jan 12, 2025
| ByteField("logMessageInterval", 0) | ||
| ] | ||
|
|
||
| def guess_payload_class(self, payload): # type: (bytes) -> Type[Packet] |
There was a problem hiding this comment.
We typically reserve guess_payloaf for complex cases. Here a simpler approach with bind_layers is enough, and it also handles building.
| """ | ||
|
|
||
|
|
||
| class FollowUp(Packet): |
There was a problem hiding this comment.
If the packets really are empty, you don't need to include them. Having an enum in the parent that shows this type is enough.
There was a problem hiding this comment.
No, it's not empty., I have to implement fields in those packets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@polybassa @gpotter2
Here is the draft PR to add PTP protocol.
Currently this includes basic PTP header and Sync message type.
Planned additions in future commits:
post_buildfunction to calculate and insert message length field.Let me know if I have followed the correct approach.
fixes #4637