Fix typo and hidden optimizer issue

secondmind-labs · Aug 20, 2024 · bba0f1b · bba0f1b
1 parent d4949ec
commit bba0f1b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/tests/integration/test_mixed_space_bayesian_optimization.py b/tests/integration/test_mixed_space_bayesian_optimization.py
@@ -264,7 +264,7 @@ def test_optimizer_finds_minima_of_the_categorical_scaled_branin_function(
     )
 
     dataset = (
-        BayesianOptimizer(observer, mixed_search_space)
+        BayesianOptimizer(observer, problem.search_space)
         .optimize(num_steps, initial_data, model, acquisition_rule)
         .try_get_final_dataset()
     )

diff --git a/trieste/acquisition/optimizer.py b/trieste/acquisition/optimizer.py
@@ -34,7 +34,6 @@
     Box,
     CollectionSearchSpace,
     Constraint,
-    DiscreteSearchSpace,
     GeneralDiscreteSearchSpace,
     SearchSpace,
     SearchSpaceType,
@@ -735,7 +734,7 @@ def get_bounds_of_box_relaxation_around_point(
     space_with_fixed_discrete = space
     for tag in space.subspace_tags:
         if isinstance(
-            space.get_subspace(tag), DiscreteSearchSpace
+            space.get_subspace(tag), GeneralDiscreteSearchSpace
         ):  # convert discrete subspaces to box spaces.
             subspace_value = space.get_subspace_component(tag, current_point)
             space_with_fixed_discrete = space_with_fixed_discrete.fix_subspace(tag, subspace_value)