Make get_unique_points more efficient #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 0.3, | ||
| tf.constant([True, True, False, True, False, True, False, True]), | ||
| ), | ||
| ( | ||
| tf.constant([[1.0], [2.0], [1.0], [3.0], [1.699999], [1.71], [3.300001], [3.29]]), | ||
| tf.constant([[1.0], [2.0], [1.0], [3.0], [2.10001], [2.1], [3.300001], [3.29]]), |
There was a problem hiding this comment.
This seems problematic. The 2.10001 point is only 0.10001 away and well within the tolerance of 0.3 but is still marked as unique. I hadn't quite realised that the rounding boundary had such a big error effect.
|
Closing PR following offline discussion. Will create a separate PR for parallelising the existing greedy set cover algorithm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs: #781
Summary
Make get_unique_points more efficient and document its precise behaviour.
Fully backwards compatible: ish
The behaviour changes as we now use rounding to select points rather than a distance based loop. But the old behaviour was never fully documented, and the rounding approach should work fine for BatchTrustRegionBox.get_initialize_subspaces_mask which is the only place we currently use it.
PR checklist