Add zeta param to control TR eps init
#832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hstojic
approved these changes
Mar 21, 2024
trieste/acquisition/rule.py
Outdated
| @@ -1544,6 +1545,8 @@ def __init__( | |||
| :param beta: The inverse of the trust region contraction factor. | |||
| :param kappa: Scales the threshold for the minimal improvement required for a step to be | |||
| considered a success. | |||
| :param zeta: The initial size of the search space is ``zeta`` times the size of the global | |||
There was a problem hiding this comment.
Suggested change
| :param zeta: The initial size of the search space is ``zeta`` times the size of the global | |
| :param zeta: The initial size of the trust region is ``zeta`` times the size of the global |
trieste/acquisition/rule.py
Outdated
| @@ -2121,6 +2124,8 @@ def __init__( | |||
| :param beta: The inverse of the trust region contraction factor. | |||
| :param kappa: Scales the threshold for the minimal improvement required for a step to be | |||
| considered a success. | |||
| :param zeta: The initial size of the search space is ``zeta`` times the size of the global | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs:
Summary
Updated how
epsis initialized forSingleObjectiveTrustRegionBoxandSingleObjectiveTrustRegionDiscreteregions. There is a newzetaparameter to control this.Fully backwards compatible: yes
PR checklist