Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where TREGO zeta init arg was missing #842

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix bug where TREGO zeta init arg was missing #842

merged 1 commit into from
May 16, 2024

Conversation

khurram-ghani
Copy link
Collaborator

Related issue(s)/PRs:

Summary

Add missing zeta arg for TREGO.

Fully backwards compatible: yes

PR checklist

  • The quality checks are all passing
  • The bug case / new feature is covered by tests
  • Any new features are well-documented (in docstrings or notebooks)

uri-granta
uri-granta approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test that would have caught this?

@khurram-ghani
Copy link
Collaborator Author

can we add a test that would have caught this?

As discussed, I don't think that is simple to do.

@khurram-ghani khurram-ghani merged commit adcd419 into develop May 16, 2024
12 checks passed
@khurram-ghani khurram-ghani deleted the khurram/fix_trego_zeta_bug branch May 16, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-granta uri-granta uri-granta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khurram-ghani @uri-granta