Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: fix filesystem path, filename manipulation issue #1131

Conversation

rajithkrishnegowda
Copy link
Collaborator

@rajithkrishnegowda rajithkrishnegowda commented Nov 8, 2024

This PR introduces the ability to specify a log file path via the --log-file command-line option in the CLI.
Screenshot 2024-11-08 at 2 53 00 PM

Fixing Path manipulation coverity issue
Log File Details:

  • Option: --log-file
  • Default Path: logs/app.log
  • Validation: The log file path is validated to ensure it:
    • Is within the logs directory.
    • Does not contain directory traversal characters (..).
    • Does not start with an absolute path indicator (/).

@rajithkrishnegowda rajithkrishnegowda changed the title fix filesystem path, filename manipulation issue WIP: fix filesystem path, filename manipulation issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant