Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring to facilitate doc generation for dockerize subcommand #1136

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ishaileshpant
Copy link
Collaborator

No description provided.

…ize` command

- Rebased - 11/Nov/2024
Signed-off-by: Shailesh Pant <[email protected]>
@ishaileshpant ishaileshpant changed the title [WIP] Add docstring to facilitate doc generation for dockerize subcommand Add docstring to facilitate doc generation for dockerize subcommand Nov 11, 2024
Comment on lines +414 to +424
Parameters:
context: The context object that provides access to shared information and methods,such as invoking other commands or accessing configuration settings.
save (bool): If True, saves the workspace Docker image as a tarball (`.tar`) file.
rebuild (bool): If True, forces a rebuild of the Docker images without using the cache.
revision (str): Specifies the OpenFL revision to use as a build argument in the Docker build process.

Returns:
None

Raises:
RuntimeError: If any of the Docker commands fail during execution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This portion isn't required, click generates argument-specific docstrings from the options decorators.

To package the workspace and save the Docker image as a tarball:

```python
dockerize_(context, save=True, rebuild=False, revision='main')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users won't be calling the python functions, so I suggest providing command examples.

@MasterSkepticista
Copy link
Collaborator

@ishaileshpant With #1140 merged, this readme provides (incomplete) details on how to use dockerize subcommand. I am open to ideas on how (and where) to best document practices on how to run an enclave-enabled container.

@ishaileshpant
Copy link
Collaborator Author

@ishaileshpant With #1140 merged, this readme provides (incomplete) details on how to use dockerize subcommand. I am open to ideas on how (and where) to best document practices on how to run an enclave-enabled container.

May be first thing is to fix this readme or link a doc specifically detailing enclave based run possibly here https://github.com/securefederatedai/openfl/tree/develop/docs/developer_guide/advanced_topics - wdyt @MasterSkepticista ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants