-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workflow Interface] Refactor FLSpec and Runtime to enhance modularity #1363
Open
ishant162
wants to merge
60
commits into
securefederatedai:develop
Choose a base branch
from
ishant162:runtime_refactor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 51 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
9190c2e
local_runtime refactor initial commit
ishant162 c59508d
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 2aa528a
fix format
ishant162 9ec51ce
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 43ff9f9
Optimized code
ishant162 912119a
federated_runtime refactor
ishant162 f537e11
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 61f1a5d
federated_runtime refactor optimization
ishant162 a973959
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 d13ac8a
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 2bc3898
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 151484e
Updated flspec.py
ishant162 dcc7d61
updated aggregator.py
ishant162 d8a552c
update federated_runtime
ishant162 120878f
Merge branch 'develop' into runtime_refactor
ishant162 de6dbbb
updated federated_runtime
ishant162 ab75dca
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 a416b5d
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 4fce1b2
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 617a5b7
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 072fcfc
Updated federated_runtime.py
ishant162 af11aab
Incorporated internal review comments
ishant162 58d32af
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 3127f68
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 e7220bc
Incorporated internal review comments
ishant162 7732987
Incorporated review comments
ishant162 c4c5d9f
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 b984789
Incorporated review comments
ishant162 dc0d2af
Updated FederatedRuntime testcases
ishant162 de86fe6
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 f22a379
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 9a568c7
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 9fbcb23
update docstring
ishant162 b1653d3
updated and restructured code
ishant162 d8649b1
updating 101_MNIST
ishant162 56e5313
updating 101_MNIST
ishant162 62c5505
updating 101_MNIST
ishant162 b1ec130
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 5de433c
Incorporated review comments
ishant162 5143a7c
Update documentation
ishant162 52b702c
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 95076ee
Update documentation
ishant162 dba31f5
Incorporated review comments
ishant162 234a80c
Updated documentation
ishant162 0a51540
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 c49ae86
Merge branch 'develop' into runtime_refactor
payalcha abf6d44
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 3ad2e30
Review comments incorporated
ishant162 4fab86e
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 6a5fcb2
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 ecb7b63
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 0e30108
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 b72e7de
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 c6a696b
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 d3696d4
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 d7b4b59
Update federated_runtime
ishant162 b1fc0ce
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 f28f842
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 3d45d8c
Updated testcase
ishant162 5438228
Merge branch 'securefederatedai:develop' into runtime_refactor
ishant162 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this add a reserved keyword
collaborators
to the flow spec. I assume this is set statically at the start of the workflow execution? Is there any way to get an updated collaborator from inside the workload? Use case - for theFederatedRuntime
if additional envoys registered with the director, how could they join the federation after experiment start (assume TLS is setup and handled)? With the current API (self.collaborators = self.runtime.collaborators
), the flow could (in a future release) get access to this list by querying the runtime. This is a capability of the RANO fork of OpenFL used in the real world; where not all collaborators will necessarily be ready (or known) at the start of an experiment.