Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

401 tutorial experimental #862

Merged

Conversation

GabrieleRoncolato
Copy link
Contributor

Implementation of a 401 tutorial for workflow interface

@psfoley psfoley self-requested a review July 13, 2023 21:23
Copy link
Contributor

@psfoley psfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GabrieleRoncolato, @Albio-dev, @Rickybolo99, @leofracca, and @MDV-droid for the contribution! To summarize, this combines the examples from the prior workflow interface notebook examples and demonstrates them running together? It looks like a lot of files got included (datasets, metaflow artifacts, final model, etc.) by mistake. Once those are removed, I think this is ready to merge 🚀

Also, could you retroactively sign the DCO per these instructions? Thanks!

@GabrieleRoncolato
Copy link
Contributor Author

Yes, this example combines the prior workflow interface examples together.
I have read the guide regarding how to sign the DCO, however in our case we need to sign each commit individually, is there a guide regarding how to do that?
Once we have solved this issue we will also proceed with removing the additional files, thank you!

@GabrieleRoncolato
Copy link
Contributor Author

We have updated the pull request by removing the unnecessary files and signing all commits as required, we have also included an authors section in the notebook.
Being unable to sign each commit using a different key, @leofracca verified all commits.

Copy link
Contributor

@psfoley psfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the remaining review comment is addressed, this is ready to merge!

Signed-off-by: leofracca <[email protected]>
@psfoley psfoley merged commit 79b8dbc into securefederatedai:develop Nov 7, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants