Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): add storybook #53

Merged
merged 1 commit into from
Apr 23, 2024
Merged

build(deps): add storybook #53

merged 1 commit into from
Apr 23, 2024

Conversation

kahboom
Copy link
Collaborator

@kahboom kahboom commented Apr 19, 2024

This PR adds support for Storybook and adds a basic story for every presentational component.

NOTE TO REVIEWERS: I'll leave this PR open through the weekend and will be merged Monday if builds are passing (with the exception of a known issue with Konflux build) and no requests for changes are made.

Changes:

Follow-up PRs coming shortly with CI/CD action, support for Pages and Screens and similar, and improved stories.

Storybook

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.46%. Comparing base (47b4e69) to head (b19e1e7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files          13       13           
  Lines        1511     1511           
  Branches       48       37   -11     
=======================================
  Hits          959      959           
  Misses        552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kahboom kahboom force-pushed the storybook branch 10 times, most recently from 712c932 to 59fc34a Compare April 23, 2024 13:40
chore: add storybook + stories for most components

chore: add remaining stories

add storybook add-ons plugin

formatting

add lint-staged

update README

ignore stories for eslint

ignore stories for eslint

ignore for storybook directory

don't ignore stories

update glob pattern again

exclude stories and mdx files from eslint by reviewdog

testing

fix newline
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kahboom kahboom merged commit 37b6398 into main Apr 23, 2024
14 of 15 checks passed
@kahboom kahboom deleted the storybook branch April 23, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants