Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update action on pr #30

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Update action on pr #30

merged 2 commits into from
Oct 6, 2023

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Oct 6, 2023

updating workflow to run with PRs

@sallyom
update to run lint-charts on PR
b52e6c0 
Signed-off-by: Sally O'Malley <[email protected]>
@sallyom
Copy link
Collaborator Author

sallyom commented Oct 6, 2023 •
edited
Loading

I learned that ct install --config ct-install.yaml is all we need - that command installs & runs helm test so I removed the extra helm install from the workflow

NAME: trusted-artifact-signer-x922e60aoy
LAST DEPLOYED: Fri Oct  6 18:53:27 2023
NAMESPACE: trusted-artifact-signer-x922e60aoy
STATUS: deployed
REVISION: 1
TEST SUITE:     trusted-artifact-signer-test-connection
Last Started:   Fri Oct  6 18:57:[43](https://github.com/securesign/sigstore-ocp/actions/runs/6435401118/job/17476585469#step:11:44) 2023
Last Completed: Fri Oct  6 18:57:[45](https://github.com/securesign/sigstore-ocp/actions/runs/6435401118/job/17476585469#step:11:46) 2023
Phase:          Succeeded

lance
lance approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks Sally

@lance lance merged commit 90324c7 into securesign:main Oct 6, 2023
2 checks passed
lkatalin pushed a commit to lkatalin/sigstore-ocp that referenced this pull request Oct 16, 2023
@sallyom @lkatalin
Update action on pr (securesign#30)
934f137 
* update to run lint-charts on PR

Signed-off-by: Sally O'Malley <[email protected]>

* bump chart

---------

Signed-off-by: Sally O'Malley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sallyom @lance