-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Containerfile for tas-clients #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @sallyom it's so much easier than I had envisioned!
Signed-off-by: Sally O'Malley <[email protected]>
b794a95
to
24be2f0
Compare
Signed-off-by: Sally O'Malley <[email protected]>
62080f9
to
740fc6f
Compare
tas-clients/Containerfile
Outdated
summary="Red Hat serves Trusted Artifact Signer CLI binaries" \ | ||
description="Serves Trusted Artifact Signer CLI binaries from server" \ | ||
io.k8s.display-name="Red Hat serves Trusted Artifact Signer CLI binaries" \ | ||
maintainer="[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we actually have a real email address here? Either we create this email with an internal GGroup, or use something that someone monitors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These labels were a best guess - I remember you said we had to add labels to all of our images - so I figured I'd follow suit w/ whatever we need there
manage sigstore artifacts. | ||
displayName: cosign - Command Line Interface (CLI) | ||
links: | ||
- href: https://tas-clients-trusted-artifact-signer.apps.open-svc-sts.k1wl.p1.openshiftapps.com/clients/cosign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gets replaced with the OPENSHIFT_BASE_DOMAIN
value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup - this will be dynamic with the helm template files & values.yaml substitution - I just have to move it over to the templates folder and add some {{ blah.blah.blah }} - and also this will be a new section in our chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
serviceAccountName: tas-clients | ||
containers: | ||
- name: tas-clients | ||
image: quay.io/sallyom/tas-clients:httpd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chicken, meet egg. This should change to a rhtas image URI right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we'll need to onboard the image, see the Containerfile above! Also, we still need to change out the
quay.io/sallyom/copy-secrets-job:latest
image in our values.yaml
40235f7
to
0258477
Compare
0258477
to
f98e9b4
Compare
Signed-off-by: Sally O'Malley <[email protected]>
f98e9b4
to
826d7b9
Compare
Signed-off-by: Sally O'Malley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
* initial Containerfile for tas-clients * add cli-server * add clientserver to chart, templates * add auxiliary Containerfiles * clientserver route,console opts --------- Signed-off-by: Sally O'Malley <[email protected]>
@lance ptal
TODO:
Running as a PoC here and the httpd server is running in ns
trusted-artifact-signer
in that cluster.