Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Containerfile for tas-clients #33

Merged
merged 5 commits into from
Oct 13, 2023
Merged

Conversation

sallyom
Copy link
Collaborator

@sallyom sallyom commented Oct 10, 2023

@lance ptal

TODO:

  • add rekor-cli & whatever else

Running as a PoC here and the httpd server is running in ns trusted-artifact-signer in that cluster.

Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @sallyom it's so much easier than I had envisioned!

Signed-off-by: Sally O'Malley <[email protected]>
summary="Red Hat serves Trusted Artifact Signer CLI binaries" \
description="Serves Trusted Artifact Signer CLI binaries from server" \
io.k8s.display-name="Red Hat serves Trusted Artifact Signer CLI binaries" \
maintainer="[email protected]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we actually have a real email address here? Either we create this email with an internal GGroup, or use something that someone monitors?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These labels were a best guess - I remember you said we had to add labels to all of our images - so I figured I'd follow suit w/ whatever we need there

manage sigstore artifacts.
displayName: cosign - Command Line Interface (CLI)
links:
- href: https://tas-clients-trusted-artifact-signer.apps.open-svc-sts.k1wl.p1.openshiftapps.com/clients/cosign
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gets replaced with the OPENSHIFT_BASE_DOMAIN value?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - this will be dynamic with the helm template files & values.yaml substitution - I just have to move it over to the templates folder and add some {{ blah.blah.blah }} - and also this will be a new section in our chart.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated!

serviceAccountName: tas-clients
containers:
- name: tas-clients
image: quay.io/sallyom/tas-clients:httpd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chicken, meet egg. This should change to a rhtas image URI right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we'll need to onboard the image, see the Containerfile above! Also, we still need to change out the
quay.io/sallyom/copy-secrets-job:latest image in our values.yaml

@sallyom sallyom changed the title initial Containerfile for tas-clients WIP: initial Containerfile for tas-clients Oct 13, 2023
@sallyom sallyom force-pushed the clients-image branch 6 times, most recently from 40235f7 to 0258477 Compare October 13, 2023 16:53
@sallyom sallyom changed the title WIP: initial Containerfile for tas-clients Initial Containerfile for tas-clients Oct 13, 2023
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lance lance merged commit 3a85c3f into securesign:main Oct 13, 2023
2 checks passed
lkatalin pushed a commit to lkatalin/sigstore-ocp that referenced this pull request Oct 16, 2023
* initial Containerfile for tas-clients
* add cli-server
* add clientserver to chart, templates
* add auxiliary Containerfiles
* clientserver route,console opts

---------

Signed-off-by: Sally O'Malley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants