Configuring dockerfile for rhtap build

[tommyd450]

No description provided.

[lance]

I'm not sure about calling go mod vendor and go install in a hermetic environment. I don't see how that will work.

[tommyd450]

/retest

[tommyd450]

/retest

[tommyd450]

/retest

[tommyd450]

/retest

[Gregory-Pereira]

/lgtm
Everything looks great, I approve these changes as is. I had some additional optimization suggestions if you are interested, but if you dont want to fight with tests again feel free to merge what you have here.

[Gregory-Pereira]

Personally I recommend you swap out the COPY command for ADD. If you keep the strategy they started with, the image should be significantly smaller as you dont have to load every file from the directory in, only the ones used for go package management and building the binary. This should work if you create the directories as mentioned above.

Suggested change

	COPY . .
	ADD go.mod go.sum $APP_ROOT/src/
	RUN go mod download
	# Add source code
	ADD ./cmd/ $APP_ROOT/src/cmd/
	ADD ./pkg/ $APP_ROOT/src/pkg/

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Gregory-Pereira, tommyd450

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[lance]

@Gregory-Pereira your comments are useful. I'm going to go ahead and merged so we can make progress, and then these kinds of changes @tommyd450 can pick up in spare cycles.