Add backwards compatibility for px size preferences saved

seek-oss · Sep 11, 2024 · b7c41ca · b7c41ca
1 parent 8e50103
commit b7c41ca
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/src/StoreContext/StoreContext.tsx b/src/StoreContext/StoreContext.tsx
@@ -481,6 +481,8 @@ export const StoreProvider = ({
     Promise.all([
       store.getItem<string>('code'),
       store.getItem<EditorPosition>('editorPosition'),
+      store.getItem<number>('editorHeight'), // Deprecated
+      store.getItem<number>('editorWidth'), // Deprecated
       store.getItem<string>('editorHeightPercentage'),
       store.getItem<string>('editorWidthPercentage'),
       store.getItem<number[]>('visibleWidths'),
@@ -490,27 +492,37 @@ export const StoreProvider = ({
       ([
         storedCode,
         storedPosition,
-        storedHeight,
-        storedWidth,
+        storedHeight, // Deprecated
+        storedWidth, // Deprecated
+        storedHeightPercentage,
+        storedWidthPercentage,
         storedVisibleWidths,
         storedVisibleThemes,
         storedColorScheme,
       ]) => {
         const code = codeFromQuery || storedCode || exampleCode;
         const editorPosition = storedPosition;
+
         const editorHeightPercentage =
-          storedHeight || defaultEditorSizePercentage;
+          storedHeightPercentage ||
+          (storedHeight ? `${storedHeight}px` : null) ||
+          defaultEditorSizePercentage;
+
         const editorWidthPercentage =
-          storedWidth || defaultEditorSizePercentage;
+          storedWidthPercentage ||
+          (storedWidth ? `${storedWidth}px` : null) ||
+          defaultEditorSizePercentage;
         const visibleWidths =
           widthsFromQuery ||
           storedVisibleWidths ||
           playroomConfig?.defaultVisibleWidths;
+
         const visibleThemes =
           hasThemesConfigured &&
           (themesFromQuery ||
             storedVisibleThemes ||
             playroomConfig?.defaultVisibleThemes);
+
         const colorScheme = storedColorScheme;
 
         dispatch({