Add new faviconPath option
#312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 187b820 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jordanoverbye
commented
Jan 5, 2024
| // Use the favicon from the config if specified, otherwise don't use anything | ||
| const favicon = playroomConfig.faviconPath | ||
| ? relativeResolve(playroomConfig.faviconPath) | ||
| : undefined; |
There was a problem hiding this comment.
I've defaulted to undefined here because I believe the /images folder is not published to npm, and I'm not sure if you want to do that. However, I'm happy to change this if needed.
|
SVG icons aren't supported at all in Safari, and some mobile browsers. I would suggest that it's not worth worse browser support for a slight simplification. This issue can be fixed without also adding a feature too. The feature should be discussed/implemented separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #311 (which appears to be breaking builds in version
0.34.1) by adding a newfaviconPathoption.I've also tried to simplify the favicon implementation by replacing the
favicon.pngandfavicon-inverted.pngfiles with a single SVG favicon.