Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide explicit port for all projects #370

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

felixhabib
Copy link
Contributor

Ensure both basic and typescript projects have an explicit port, similar to themed.

This change prevents some issues running the typescript project locally, with the port not falling back to the expected value.

Adding the expected port to the basic project as well for explicitness and consistency.

@felixhabib felixhabib requested a review from a team as a code owner October 9, 2024 23:50
Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 7eda3c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixhabib felixhabib enabled auto-merge (squash) October 9, 2024 23:51
@felixhabib felixhabib merged commit cb726c7 into master Oct 9, 2024
6 checks passed
@felixhabib felixhabib deleted the set-explicit-port-for-all-projects branch October 9, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants