Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mentee route and status validation, unit test were previously in … #135

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dsmabulage
Copy link
Contributor

…the code

Purpose

The purpose of this PR is to fix #31

Goals

  1. Add route mapping
  2. Add TODO comment for invalid route path
  3. Add status ENUM validation for mentee status
  4. Unit tests were already there.

Approach

  1. Add small route mapping for mentees
  2. Method was already written in the existing code
  3. Add status validation for query param

Screenshots

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

anjula-sack pushed a commit to anjula-sack/scholarx-backend that referenced this pull request Jul 23, 2024
@anjula-sack
Copy link
Member

Impressive work @dsmabulage, Would you like to join our engineering team? You can read more about us here: https://handbook.sefglobal.org/engineering-team/team

@dsmabulage
Copy link
Contributor Author

Impressive work @dsmabulage, Would you like to join our engineering team? You can read more about us here: https://handbook.sefglobal.org/engineering-team/team

Thank you for the opportunity! I'm very interested and will check out the link. Looking forward to learning more about the team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Get all mentees by status endpoint (Admin)
3 participants