Implment Monthly-Checking API Endpoint #172
Merged
+410
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved monthly checking service functions to a dedicated service file (monthlyChecking.service.ts). - Moved monthly checking controller functions to a dedicated controller file (monthlyChecking.controller.ts). - Updated import paths and references to reflect the new file structure. - Improved code organization and maintainability by separating concerns.
anjula-sack
requested changes
Sep 29, 2024
anjula-sack
requested changes
Oct 5, 2024
Comment on lines
93
to
104
| checkIns: Array<{ | ||
| uuid: string | ||
| title: string | ||
| generalUpdatesAndFeedback: string | ||
| progressTowardsGoals: string | ||
| mediaContentLinks: string[] | ||
| mentorFeedback: string | null | ||
| isCheckedByMentor: boolean | ||
| mentorCheckedDate: Date | null | ||
| checkInDate: Date | ||
| mentee: Mentee | ||
| }> |
There was a problem hiding this comment.
Create the CheckIn type at types.ts
Comment on lines
132
to
143
| const checkInsWithUuid = checkIns.map((checkIn) => ({ | ||
| uuid: checkIn.uuid, | ||
| title: checkIn.title, | ||
| generalUpdatesAndFeedback: checkIn.generalUpdatesAndFeedback, | ||
| progressTowardsGoals: checkIn.progressTowardsGoals, | ||
| mediaContentLinks: checkIn.mediaContentLinks, | ||
| mentorFeedback: checkIn.mentorFeedback, | ||
| isCheckedByMentor: checkIn.isCheckedByMentor, | ||
| mentorCheckedDate: checkIn.mentorCheckedDate, | ||
| checkInDate: checkIn.checkInDate, | ||
| mentee: checkIn.mentee | ||
| })) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #157
Goals
Approach
Implemened controller and service for monthly checking api endpoint
Created a new service file monthlyChecking.service.ts to handle the business logic for monthly checking.
Implemented the addMonthlyCheckIn, fetchMonthlyCheckIns and addFeedbackByMentorfunctions in the service file.
Updated the controller to call the appropriate service functions.
Screenshots
Checklist
Related PRs
Test environment
Os: Linux Mint 21.3
Nodejs: 20.15.0
Learning