Get all users endpoint #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into get-all-users-endpoint
anjula-sack
requested changes
Aug 12, 2023
There was a problem hiding this comment.
The eslint is failing @Shrenik0321 can you check it? Also can you refer to this directory structure?
controllers
- admin
- user
- mentee
- mentor
- platform
anjula-sack
requested changes
Aug 12, 2023
src/routes/admin/admin.route.test.ts
Outdated
|
|
||
| const userProfiles = response.body | ||
|
|
||
| userProfiles.forEach((userProfile: Object) => { |
There was a problem hiding this comment.
Suggested change
| userProfiles.forEach((userProfile: Object) => { | |
| userProfiles.forEach((userProfile: Partial<Profile>) => { |
…into get-all-users-endpoint
…21/scholarx-backend into get-all-users-endpoint
anjula-sack
requested changes
Aug 19, 2023
| res: Response | ||
| ): Promise<any> => { | ||
| try { | ||
| const users = await getAllUsers(req) |
There was a problem hiding this comment.
Suggested change
| const users = await getAllUsers(req) | |
| const users = await getAllUsers() |
You need to check the user type here. user type should be ADMIN otherwise throw 403 unauthorized
src/services/admin.service.ts
Outdated
Comment on lines
5
to
7
| export const getAllUsers = async ( | ||
| req: Request | ||
| ): Promise<Profile[] | undefined> => { |
There was a problem hiding this comment.
Suggested change
| export const getAllUsers = async ( | |
| req: Request | |
| ): Promise<Profile[] | undefined> => { | |
| export const getAllUsers = async ( ): Promise<Profile[] | undefined> => { |
anjula-sack
requested changes
Aug 20, 2023
src/controllers/auth.controller.ts
Outdated
Comment on lines
10
to
20
| const { email, password, type } = req.body | ||
|
|
||
| if (!email || !password) { | ||
| res.status(400).json({ error: 'Email and password are required fields' }) | ||
| } | ||
|
|
||
| const { statusCode, message, profile } = await registerUser(email, password) | ||
| const { statusCode, message, profile } = await registerUser( | ||
| email, | ||
| password, | ||
| type | ||
| ) |
There was a problem hiding this comment.
You should not update this to send the type. With this anyone can become an admin. @Shrenik0321
There was a problem hiding this comment.
Oh right. understood
anjula-sack
reviewed
Aug 20, 2023
src/routes/admin/admin.route.test.ts
Outdated
Comment on lines
32
to
41
| const adminUser = { | ||
| email: `test${randomStringAdmin}@gmail.com`, | ||
| password: 'admin123', | ||
| type: 'admin' | ||
| } | ||
|
|
||
| await supertest(server) | ||
| .post('/api/auth/register') | ||
| .send(adminUser) | ||
| .expect(201) |
There was a problem hiding this comment.
Use the dataSource to create an admin
There was a problem hiding this comment.
const adminUser = {
email: `test${randomStringAdmin}@gmail.com`,
password: 'admin123',
}
const profileRepository = dataSource.getRepository(Profile)
const hashedPassword = await bcrypt.hash(adminUser.password, 10)
const newProfile = profileRepository.create({
primary_email: .adminUser.email,
password: hashedPassword,
contact_email: '',
first_name: '',
last_name: '',
image_url: '',
linkedin_url: '',
type: ProfileTypes.ADMIN
})
await profileRepository.save(newProfile)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to fix #34
Goals
Approach
Screenshots
Checklist
Related PRs
Test environment
Learning