This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Convered all Object based key-value stores to Maps #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated all key-value Objects (specifically,
packages
andexportNames
in dependency-report.js andfilepathsForExports
in package.js) to use Map.This is to resolve problems when names or packages conflict with keys from
Object.prototype
.Examples of this problem are lines like:
import toString from ‘lodash/toString’
This would result in the key-value stores not getting initialized because:
if (!this.filepathsForExports['toString']) {
will never evaluate false.
Methods on DependencyReport and Package were updated to ensure consistency with the existing API