Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Matcher portion of the tsub code to be able to generate functions, instead of interpreting the string every time.
This reduces the time when the matchers are long lived and execute several times. This is particularly useful for destination filters on mobile SDKs.
Performance Comparison
Before:
After:
Using this FQL:
To keep compatibility the
matches
function executes exactly as before (generating the evaluator and executing it right away) and added agetMatcherFunction
to actually return the generated function that the consumer can save for performance.Future work
transformers
store
(this might have more impact on dependent packages)