Add msgs for updating unlocked distribution address and staking rewards distribution address #19
Conversation
| let msg = ExecuteMsg::InternalUpdateUnlockedDistributionAddress { | ||
| unlocked_distribution_address: unlocked_distribution_address.clone(), | ||
| }; | ||
| let title = format!("updating unlocked distribution address {}", unlocked_distribution_address.to_string()); |
There was a problem hiding this comment.
is this title sufficient? not too sure how it's used
| @@ -1072,6 +1154,19 @@ mod tests { | |||
| .add_attribute("proposal_id", 1.to_string()) | |||
| .add_attribute("status", "Open") | |||
| ); | |||
|
|
|||
| // Verify admin has updated after internal call | |||
There was a problem hiding this comment.
add more assertions similar to new ones to ensure that the actual storage values are updated
There was a problem hiding this comment.
we also need to update the version here https://github.com/sei-protocol/gringotts/blob/main/Cargo.toml#L3
and also the changelog https://github.com/sei-protocol/gringotts/blob/main/CHANGELOG.md
thanks! i actually got an error when testing migration so i bumped it remotely but forgot to make local changes |
philipsu522
requested review from
yzang2019 and
besated
and removed request for
stevenlanders
Describe your changes and provide context
Add messages to allow for updating unlocked distribution address and staking rewards distribution address.
Testing performed to validate your change
Unit tests, and also verified on autobake cluster