Support partial withdraw for unlocked tokens #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipsu522
approved these changes
Jul 9, 2024
Comment on lines
+31
to
+35
| VESTING_AMOUNTS.save(storage, &vec![])?; | ||
| VESTING_TIMESTAMPS.save(storage, &vec![])?; |
There was a problem hiding this comment.
do we want these to be mutable? or do we want to introduce more state to track? i'm fine either way (we can always query the contract state in the past)
There was a problem hiding this comment.
yeah we always have the instantiate state so I feel like we can just reuse these for modifications
src/vesting.rs
Outdated
| @@ -91,11 +120,26 @@ mod tests { | |||
| .unwrap(); | |||
| VESTING_AMOUNTS.save(deps_mut.storage, &vec![10]).unwrap(); | |||
|
|
|||
| assert_eq!(10, collect_vested(deps_mut.storage, now).unwrap()); | |||
| assert_eq!(10, collect_vested(deps_mut.storage, now, 15).unwrap()); | |||
There was a problem hiding this comment.
so the current logic allows one to specify withdrawing more than is vested? would it be better to force the user to specify the exact amount and error out instead?
There was a problem hiding this comment.
I'll defer to you on that since you'd often be the one initiating the withdrawal (like if getting exact amount is not hard then yeah we can add a check here)
codchen
force-pushed
the
partial-withdrawal
branch
from
bdad659 to
34c6d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Allow passing in an
amountfield that specifies the upper limit of unlocked tokens one wishes to initiate withdrawal for. Specifically,amount, the total amount would be withdrawnamount,amountwould be withdrawn, and the first slot of the remaining tranche will have its amount deducted accordingly.Testing performed to validate your change
unit test
local sei