Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sei2_getBlock endpoints to include bank transfers #2064

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jan 31, 2025

Describe your changes and provide context

Add a new version of sei2_getBlock... endpoints that include bank transfers. Specifically any usei bank transfer will show up as a transaction in the transactions field of the _getBlock responses, with from being the sender, to being the recipient, and input being the amount (serialized as bytes and in terms of wei)

Testing performed to validate your change

unit test
localsei
Screenshot 2025-01-31 at 2 11 05 PM

@codchen codchen force-pushed the tony/show-bank-transfer-in-rpc branch 2 times, most recently from a0d5a6c to 2b3898c Compare January 31, 2025 06:12
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 81.08108% with 7 lines in your changes missing coverage. Please review.

Project coverage is 61.59%. Comparing base (6788468) to head (0996a38).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
evmrpc/block.go 78.78% 3 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2064      +/-   ##
==========================================
+ Coverage   61.34%   61.59%   +0.25%     
==========================================
  Files         264      264              
  Lines       24632    24608      -24     
==========================================
+ Hits        15111    15158      +47     
+ Misses       8387     8321      -66     
+ Partials     1134     1129       -5     
Files with missing lines Coverage Δ
evmrpc/server.go 87.13% <100.00%> (+0.30%) ⬆️
evmrpc/block.go 76.11% <78.78%> (+0.14%) ⬆️

... and 4 files with indirect coverage changes

@codchen codchen force-pushed the tony/show-bank-transfer-in-rpc branch from 2b3898c to 0996a38 Compare January 31, 2025 14:03
@jewei1997 jewei1997 merged commit c2bc99c into main Jan 31, 2025
49 checks passed
@jewei1997 jewei1997 deleted the tony/show-bank-transfer-in-rpc branch January 31, 2025 15:26
jewei1997 pushed a commit that referenced this pull request Jan 31, 2025
* add sei2_getBlock endpoints to include bank transfers

* unit test
philipsu522 pushed a commit that referenced this pull request Jan 31, 2025
* add sei2_getBlock endpoints to include bank transfers

* unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants