Set log index across all transactions in a block #2067
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Previously if we have two EVM transactions in the same block, each with 1 log, both logs will have log index of 0, because log index was set relative to each transaction. The expected behavior is for log index to be set across transactions in a block (i.e. the log of the first tx would have index 0, whereas the log of the second would have index 1).
It is not quite feasible to set log index as such during execution though, because transactions may be processed in parallel, so this PR adds backfill log on the read path instead.
Testing performed to validate your change
unit test