Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SeiDB] Part1: Add root multistore v2 in cosmos sdk #373

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Conversation

yzang2019
Copy link
Collaborator

@yzang2019 yzang2019 commented Dec 8, 2023

Describe your changes and provide context

  • This change is adding a storageV2 multistore which is going to manage both CommitStore and StateStore on together.
  • To make things backward compatible, we are not modifying the original root multistore, and we created a new package for storeV2 multistore. All the interfaces are unchanged.
  • In commitment package, we added a kv store object to access SC store
  • In state package, we added a kv store object to access SS Store
  • Add seiDB specific configurations to config.toml
  • SeiDB has provided the new interface to interact with multistore

Testing performed to validate your change

All been tested locally and in loadtest cluster

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 560 lines in your changes are missing coverage. Please review.

Comparison is base (daecc34) 55.38% compared to head (93c0182) 54.79%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   55.38%   54.79%   -0.59%     
==========================================
  Files         620      622       +2     
  Lines       51605    52180     +575     
==========================================
+ Hits        28582    28594      +12     
- Misses      20940    21501     +561     
- Partials     2083     2085       +2     
Files Coverage Δ
server/config/toml.go 17.85% <ø> (ø)
x/accesscontrol/keeper/msg_server.go 50.00% <ø> (-50.00%) ⬇️
server/config/config.go 33.72% <9.52%> (-3.37%) ⬇️
storev2/commitment/store.go 12.94% <12.94%> (ø)
storev2/rootmulti/store.go 3.11% <3.11%> (ø)

... and 1 file with indirect coverage changes

@yzang2019 yzang2019 changed the title [Cosmos] Part1: Add root multistore v2 in cosmos sdk [SeiDB] Part1: Add root multistore v2 in cosmos sdk Dec 8, 2023
@yzang2019 yzang2019 merged commit 175cc39 into main Dec 27, 2023
14 of 15 checks passed
@yzang2019 yzang2019 deleted the yzang/SEI-6175 branch December 27, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants