Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write estimates even on abort to provide partial estimation of tx writeset #455

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

udpatil
Copy link
Contributor

@udpatil udpatil commented Mar 12, 2024

Describe your changes and provide context

This writes estimated writeset for txs that end up aborting such that later txs can also refer to the writesets that the aborted tx wrote prior to aborting.

Testing performed to validate your change

Tested unit test where all txs accesses same key for maximal abort without and with the optimization (1000txs - 100 runs total time)

Without optimization:

--- PASS: TestProcessAll (10.35s)
    --- PASS: TestProcessAll/Test_every_tx_accesses_same_key (10.34s)

With optimization:

--- PASS: TestProcessAll (5.06s)
    --- PASS: TestProcessAll/Test_every_tx_accesses_same_key (5.06s)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.47%. Comparing base (a21d2bb) to head (010783d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   55.46%   55.47%   +0.01%     
==========================================
  Files         629      629              
  Lines       53523    53526       +3     
==========================================
+ Hits        29686    29695       +9     
+ Misses      21726    21720       -6     
  Partials     2111     2111              
Files Coverage Δ
tasks/scheduler.go 93.40% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

@udpatil udpatil merged commit 90becb3 into main Mar 12, 2024
13 checks passed
@udpatil udpatil deleted the write-estimate-on-abort branch March 12, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants