Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[OCC] Add sync fallback for high incarnation counts" #459

Closed
wants to merge 3 commits into from

Conversation

stevenlanders
Copy link
Contributor

Reverts #452

Copy link
Contributor

@udpatil udpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add in the unit test that tests highly conflicting workloads w/ sleeps and dependencies on all previous txs

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 55.43%. Comparing base (90becb3) to head (0b3e75b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
- Coverage   55.46%   55.43%   -0.04%     
==========================================
  Files         629      629              
  Lines       53526    53496      -30     
==========================================
- Hits        29690    29655      -35     
- Misses      21725    21728       +3     
- Partials     2111     2113       +2     
Files Coverage Δ
tasks/scheduler.go 89.34% <82.35%> (-4.07%) ⬇️

... and 1 file with indirect coverage changes

@stevenlanders
Copy link
Contributor Author

closing in favor of marching forward

@stevenlanders stevenlanders deleted the revert-452-add-sync-fallback-for-occ branch March 19, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants