Fix Panic: Check For Error Before Defer #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kbhat1
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #482 +/- ##
==========================================
- Coverage 55.35% 55.35% -0.01%
==========================================
Files 629 629
Lines 53963 53963
==========================================
- Hits 29872 29871 -1
- Misses 21957 21958 +1
Partials 2134 2134
|
philipsu522
approved these changes
Apr 10, 2024
yzang2019
approved these changes
Apr 10, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 16, 2024
## Describe your changes and provide context - Checks for err before `defer` - Without this, if there is a err, the node will panic on the `defer` because `scStore` is `nil` ## Testing performed to validate your change - Verified on node
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
## Describe your changes and provide context - Checks for err before `defer` - Without this, if there is a err, the node will panic on the `defer` because `scStore` is `nil` ## Testing performed to validate your change - Verified on node
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
## Describe your changes and provide context - Checks for err before `defer` - Without this, if there is a err, the node will panic on the `defer` because `scStore` is `nil` ## Testing performed to validate your change - Verified on node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
deferdeferbecausescStoreisnilTesting performed to validate your change