Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos Gas Multiplier Params #489

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Cosmos Gas Multiplier Params #489

merged 6 commits into from
Apr 19, 2024

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Apr 18, 2024

Describe your changes and provide context

  • Create cosmos gas multiplier params
  • Add back eventManager to cachekv

Testing performed to validate your change

  • Validated on chain

@Kbhat1 Kbhat1 requested a review from udpatil April 18, 2024 15:16
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 51.87970% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 55.51%. Comparing base (4e37eb4) to head (f835590).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
+ Coverage   55.46%   55.51%   +0.04%     
==========================================
  Files         629      631       +2     
  Lines       53549    53669     +120     
==========================================
+ Hits        29703    29793      +90     
- Misses      21734    21759      +25     
- Partials     2112     2117       +5     
Files Coverage Δ
store/cachekv/mergeiterator.go 79.87% <100.00%> (+0.65%) ⬆️
x/params/keeper/genesis.go 100.00% <100.00%> (ø)
x/params/keeper/migrations.go 100.00% <100.00%> (ø)
store/types/gas.go 80.79% <86.66%> (+0.54%) ⬆️
store/cachekv/store.go 79.91% <50.00%> (-0.92%) ⬇️
x/params/module.go 57.69% <72.72%> (+2.37%) ⬆️
x/params/keeper/keeper.go 71.42% <64.70%> (+22.49%) ⬆️
x/params/types/params.go 26.08% <52.17%> (+26.08%) ⬆️
x/params/types/genesis.go 0.00% <0.00%> (ø)
x/params/client/cli/query.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

// DefaultGenesis returns the default Capability genesis state
func DefaultGenesis() *GenesisState {
return &GenesisState{
FeesParams: *DefaultFeesParams(),
FeesParams: *DefaultFeesParams(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add anything for import / export genesis?

@udpatil udpatil merged commit 7567a55 into main Apr 19, 2024
13 checks passed
@udpatil udpatil deleted the CreateCosmosGasParams branch April 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants