Add error for evm revert #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
=======================================
Coverage 55.32% 55.32%
=======================================
Files 631 631
Lines 54173 54178 +5
=======================================
+ Hits 29970 29974 +4
- Misses 22060 22061 +1
Partials 2143 2143
|
stevenlanders
approved these changes
Jun 1, 2024
types/errors/errors.go
Outdated
| @@ -156,6 +156,9 @@ var ( | |||
| // ErrUnsupportedTxType defines an error for an unsupported transaction type (e.g., EIP-4844 transactions) | |||
| ErrUnsupportedTxType = Register(RootCodespace, 44, "unsupported transaction type") | |||
|
|
|||
| // ErrEVMVMError defines an error for an evm vm error (eg. revert) | |||
| ErrEVMVMError = Register(RootCodespace, 45, "evm vm error") | |||
There was a problem hiding this comment.
What do you think about evm reverted? (Often it's some contract validation that reverts, so it's not really a broken thing)
codchen
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This adds an error code for evm revert, and updates the tx result with it in the case of evm response containing a VM Error
Testing performed to validate your change
Tested on local chain