Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush receipt with the correct state #546

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Flush receipt with the correct state #546

merged 1 commit into from
Nov 1, 2024

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Oct 29, 2024

Describe your changes and provide context

stateToCommit could be either processProposalState or deliverState, so we should flush to the correct one. This might not be causing issue yet though, since before receipt flush, we'd first write stateToCommit to the parent state, so that deliverState would fall through to parent which is already updated by stateToCommit

Testing performed to validate your change

existing test

@codchen codchen requested a review from yzang2019 October 29, 2024 03:38
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.89%. Comparing base (02f1c2f) to head (668cfa3).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   54.89%   54.89%   -0.01%     
==========================================
  Files         631      631              
  Lines       54954    54954              
==========================================
- Hits        30169    30166       -3     
- Misses      22628    22630       +2     
- Partials     2157     2158       +1     
Files with missing lines Coverage Δ
baseapp/abci.go 52.79% <100.00%> (ø)

... and 1 file with indirect coverage changes

@codchen codchen merged commit d3830c1 into main Nov 1, 2024
15 checks passed
@codchen codchen deleted the fix-receipt-flush branch November 1, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants