Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state sync halt issue #559

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Fix state sync halt issue #559

merged 1 commit into from
Jan 3, 2025

Conversation

yzang2019
Copy link
Collaborator

Describe your changes and provide context

The issue is that when a node is exporting snapshot for wasm, it needs to reopen the SC store for a given height, which could take 10-20 minutes, during that time, we acquired a lock which blocks the block commit.

The fix is to fix the lock usage to only apply after we open the DB.

Testing performed to validate your change

Tested on state sync node

@yzang2019 yzang2019 requested review from udpatil and Kbhat1 January 2, 2025 22:27
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.86%. Comparing base (2815ef1) to head (85752e9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
storev2/rootmulti/store.go 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #559      +/-   ##
==========================================
- Coverage   54.87%   54.86%   -0.01%     
==========================================
  Files         631      631              
  Lines       54946    54946              
==========================================
- Hits        30149    30145       -4     
- Misses      22641    22644       +3     
- Partials     2156     2157       +1     
Files with missing lines Coverage Δ
storev2/rootmulti/store.go 2.56% <0.00%> (ø)

... and 2 files with indirect coverage changes

@yzang2019 yzang2019 merged commit beceb85 into main Jan 3, 2025
14 of 15 checks passed
@yzang2019 yzang2019 deleted the yzang/fix-state-sync branch January 3, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants