Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SeiDB State Store ApplyChangeset Version 0 #53

Merged
merged 5 commits into from
Jan 23, 2024
Merged

SeiDB State Store ApplyChangeset Version 0 #53

merged 5 commits into from
Jan 23, 2024

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Jan 23, 2024

Describe your changes and provide context

  • For ApplyChangeset, if version received is 0, apply changeset at version 1
  • Fixes issues with querying keys written at genesis (version 0)

Testing performed to validate your change

  • Added unit tests
  • Currently testing on node

@Kbhat1 Kbhat1 requested a review from yzang2019 January 23, 2024 17:17
alexanderbez
alexanderbez approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConceptACK

ss/pebbledb/db.go Show resolved Hide resolved
yzang2019
yzang2019 reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@yzang2019 yzang2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an integration test for this as well?

@Kbhat1
Copy link
Contributor Author

Kbhat1 commented Jan 23, 2024

Can we add an integration test for this as well?

@yzang2019 integration tests are being added here sei-protocol/sei-chain#1242 . Will add another query to admin account (to repro genesis issues)

@Kbhat1 Kbhat1 merged commit 39eb03f into main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

@yzang2019 yzang2019 yzang2019 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kbhat1 @alexanderbez @yzang2019