Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SeiDB] Fix various issues from audit #57

Merged
merged 1 commit into from
Feb 1, 2024
Merged

[SeiDB] Fix various issues from audit #57

merged 1 commit into from
Feb 1, 2024

Conversation

yzang2019
Copy link
Collaborator

Describe your changes and provide context

Fix issues found by audit

  • CleanupHandles should be called correctly
  • The fileLock is never destroyed here, leading to an unclosed file

Testing performed to validate your change

Existing unit test should cover it

@mmsqe mmsqe mentioned this pull request Feb 1, 2024
Merged
13 tasks
@yzang2019 yzang2019 merged commit dfbdadf into main Feb 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kbhat1 Kbhat1 Kbhat1 approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzang2019 @Kbhat1