Rework of PfRingDevice capture thread implementation.

[Dimi1010]

Fixes #1664.

• Added StopToken and StopTokenSource that mirror C++20's stop_token and stop_source.
• Reworked the capture thread function into a free function to simplify interactions.
  Many variables are now kept on the thread's stack instead of relying on member fields in PfRingDevice.
• Extracted the code for setting core affinity into a function.
• Cleaned up capture thread startup.

[codecov]

Codecov Report

Attention: Patch coverage is 98.38710% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (78b629f) to head (f22a741).

Files with missing lines	Patch %	Lines
Pcap++/header/StopToken.h	90.90%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #1668      +/-   ##
==========================================
+ Coverage   83.60%   83.62%   +0.02%     
==========================================
  Files         273      276       +3     
  Lines       47555    47617      +62     
  Branches     9806     9734      -72     
==========================================
+ Hits        39759    39822      +63     
+ Misses       7177     6924     -253     
- Partials      619      871     +252     

Flag	Coverage Δ
alpine320	75.16% <94.44%> (+<0.01%)	⬆️
fedora40	75.18% <94.73%> (-0.02%)	⬇️
macos-13	80.67% <100.00%> (+0.02%)	⬆️
macos-14	80.67% <100.00%> (+0.02%)	⬆️
macos-15	80.64% <100.00%> (+0.02%)	⬆️
mingw32	70.90% <93.75%> (+0.07%)	⬆️
mingw64	70.87% <93.75%> (-0.02%)	⬇️
npcap	85.31% <100.00%> (+<0.01%)	⬆️
rhel94	75.03% <94.73%> (+0.01%)	⬆️
ubuntu2004	58.61% <93.75%> (+0.02%)	⬆️
ubuntu2004-zstd	58.73% <93.75%> (+0.01%)	⬆️
ubuntu2204	74.98% <94.73%> (+0.03%)	⬆️
ubuntu2204-icpx	61.47% <100.00%> (+0.09%)	⬆️
ubuntu2404	75.21% <94.73%> (+0.01%)	⬆️
unittest	83.62% <98.38%> (+0.02%)	⬆️
windows-2019	85.34% <100.00%> (+<0.01%)	⬆️
windows-2022	85.37% <100.00%> (+<0.01%)	⬆️
winpcap	85.34% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Dimi1010]

I don't actually have a system that can run PF_RING. So it would be nice if someone could test it live.

[seladb]

@Dimi1010 this PR does a lot of things and could be broken up into multiple PRs to make it easier to review.

In order to solve #1664, wouldn't it be enough to create a shared_ptr from mutex, cond and startThread and pass them to the worker threads? 🤔

[Dimi1010]

@Dimi1010 this PR does a lot of things and could be broken up into multiple PRs to make it easier to review.

In order to solve #1664, wouldn't it be enough to create a shared_ptr from mutex, cond and startThread and pass them to the worker threads? 🤔

I suppose it can be split up.

The main fix is the startup block struct. The rest like the StopToken was added as the whole startThread being 0, 1 or 2 was a bit hard to read.

[seladb]

@Dimi1010 this PR does a lot of things and could be broken up into multiple PRs to make it easier to review.
In order to solve #1664, wouldn't it be enough to create a shared_ptr from mutex, cond and startThread and pass them to the worker threads? 🤔

I suppose it can be split up.

The main fix is the startup block struct. The rest like the StopToken was added as the whole startThread being 0, 1 or 2 was a bit hard to read.

I wouldn't add this much code just to make startThread more readable... if we can first fix #1664, potentially by using shared_ptr, it could make a great first PR. Then we can open additional PRs to add the rest of the fixes. Please let me know what you think

[Dimi1010]

@Dimi1010 this PR does a lot of things and could be broken up into multiple PRs to make it easier to review.
In order to solve #1664, wouldn't it be enough to create a shared_ptr from mutex, cond and startThread and pass them to the worker threads? 🤔

I suppose it can be split up.
The main fix is the startup block struct. The rest like the StopToken was added as the whole startThread being 0, 1 or 2 was a bit hard to read.

I wouldn't add this much code just to make startThread more readable... if we can first fix #1664, potentially by using shared_ptr, it could make a great first PR. Then we can open additional PRs to add the rest of the fixes. Please let me know what you think

Opened #1679 which is a minimal viable fix.