perf: faster equals with Object.is short circuit (#725)

selfrefactor · Feb 21, 2024 · 4e35a46 · 4e35a46
1 parent 79013c7
commit 4e35a46
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 133 deletions.
diff --git a/dist/rambda.js b/dist/rambda.js
@@ -704,6 +704,7 @@ function parseRegex(maybeRegex) {
 }
 function equals(a, b) {
   if (arguments.length === 1) return _b => equals(a, _b);
+  if (Object.is(a, b)) return true;
   const aType = type(a);
   if (aType !== type(b)) return false;
   if (aType === 'Function') return a.name === undefined ? false : a.name === b.name;

diff --git a/dist/rambda.umd.js b/dist/rambda.umd.js
diff --git a/source/__snapshots__/equals.spec.js.snap b/source/__snapshots__/equals.spec.js.snap
diff --git a/source/equals.js b/source/equals.js
@@ -82,6 +82,8 @@ function parseRegex(maybeRegex){
 export function equals(a, b){
   if (arguments.length === 1) return _b => equals(a, _b)
 
+  if (Object.is(a, b)) return true
+
   const aType = type(a)
 
   if (aType !== type(b)) return false

diff --git a/source/equals.spec.js b/source/equals.spec.js
@@ -309,7 +309,7 @@ describe('brute force', () => {
 {
   "ERRORS_MESSAGE_MISMATCH": 0,
   "ERRORS_TYPE_MISMATCH": 0,
-  "RESULTS_MISMATCH": 8,
+  "RESULTS_MISMATCH": 0,
   "SHOULD_NOT_THROW": 0,
   "SHOULD_THROW": 0,
   "TOTAL_TESTS": 289,

diff --git a/src/equals.js b/src/equals.js
@@ -82,6 +82,8 @@ function parseRegex(maybeRegex){
 export function equals(a, b){
   if (arguments.length === 1) return _b => equals(a, _b)
 
+  if (Object.is(a, b)) return true
+
   const aType = type(a)
 
   if (aType !== type(b)) return false