chore@small

selfrefactor · Nov 29, 2023 · c2bc505 · c2bc505
1 parent cc1446e
commit c2bc505
Show file tree

Hide file tree

Showing 8 changed files with 39 additions and 89 deletions.
diff --git a/.github/README.md b/.github/README.md
@@ -98,7 +98,7 @@ One of the main issues with `Ramda` is the slow process of releasing new version
 
 <details>
 <summary>
-  Click to see the full list of 0 Ramda methods not implemented in Rambda and their status.
+  Click to see the full list of 57 Ramda methods not implemented in Rambda and their status.
 </summary>
 
 - gt
@@ -1191,8 +1191,7 @@ export function append(x, input){
 <summary><strong>Tests</strong></summary>
 
 ```javascript
-// import { append } from './append.js'
-import { append } from 'ramda'
+import { append } from './append.js'
 
 test('happy', () => {
   expect(append('tests', [ 'write', 'more' ])).toEqual([
@@ -5726,35 +5725,10 @@ forEach<T, U>(fn: ObjectIterator<T, void>): (list: Dictionary<T>) => Dictionary<
 
 ```javascript
 import { isArray } from './_internals/isArray.js'
-import { keys } from './_internals/keys.js'
-
-export function forEachObjIndexedFn(fn, obj){
-  let index = 0
-  const listKeys = keys(obj)
-  const len = listKeys.length
-
-  while (index < len){
-    const key = listKeys[ index ]
-    fn(
-      obj[ key ], key, obj
-    )
-    index++
-  }
-
-  return obj
-}
-
-export function forEachObjIndexed(fn, list){
-  if (arguments.length === 1) return _list => forEachObjIndexed(fn, _list)
-
-  if (list === undefined) return
-
-  return forEachObjIndexedFn(fn, list)
-}
+import { forEachObjIndexedFn } from './forEachObjIndexed.js'
 
 export function forEach(fn, iterable){
   if (arguments.length === 1) return _list => forEach(fn, _list)
-
   if (iterable === undefined) return
 
   if (isArray(iterable)){

diff --git a/README.md b/README.md
@@ -98,7 +98,7 @@ One of the main issues with `Ramda` is the slow process of releasing new version
 
 <details>
 <summary>
-  Click to see the full list of 0 Ramda methods not implemented in Rambda and their status.
+  Click to see the full list of 57 Ramda methods not implemented in Rambda and their status.
 </summary>
 
 - gt
@@ -1130,8 +1130,7 @@ export function append(x, input){
 <summary><strong>Tests</strong></summary>
 
 ```javascript
-// import { append } from './append.js'
-import { append } from 'ramda'
+import { append } from './append.js'
 
 test('happy', () => {
   expect(append('tests', [ 'write', 'more' ])).toEqual([
@@ -5427,35 +5426,10 @@ forEach<T, U>(fn: ObjectIterator<T, void>): (list: Dictionary<T>) => Dictionary<
 
 ```javascript
 import { isArray } from './_internals/isArray.js'
-import { keys } from './_internals/keys.js'
-
-export function forEachObjIndexedFn(fn, obj){
-  let index = 0
-  const listKeys = keys(obj)
-  const len = listKeys.length
-
-  while (index < len){
-    const key = listKeys[ index ]
-    fn(
-      obj[ key ], key, obj
-    )
-    index++
-  }
-
-  return obj
-}
-
-export function forEachObjIndexed(fn, list){
-  if (arguments.length === 1) return _list => forEachObjIndexed(fn, _list)
-
-  if (list === undefined) return
-
-  return forEachObjIndexedFn(fn, list)
-}
+import { forEachObjIndexedFn } from './forEachObjIndexed.js'
 
 export function forEach(fn, iterable){
   if (arguments.length === 1) return _list => forEach(fn, _list)
-
   if (iterable === undefined) return
 
   if (isArray(iterable)){

diff --git a/dist/rambda.js b/dist/rambda.js
@@ -1295,6 +1295,7 @@ function forEachObjIndexed(fn, list) {
   if (list === undefined) return;
   return forEachObjIndexedFn(fn, list);
 }
+
 function forEach(fn, iterable) {
   if (arguments.length === 1) return _list => forEach(fn, _list);
   if (iterable === undefined) return;

diff --git a/immutable.d.ts b/immutable.d.ts
@@ -353,7 +353,7 @@ export function compose<TArgs extends readonly any[], R1, R2, R3, R4, R5, R6, R7
       f2: (a: R1) => R2,
       f1: (...args: TArgs) => R1
   ]
-): (...args: TArgs) => TResult; 
+): (...args: TArgs) => TResult;
 export function compose<TArgs extends readonly any[], R1, R2, R3, R4, R5, R6, R7, TResult>(
   f7: (a: R6) => R7,
   f6: (a: R5) => R6,

diff --git a/index.d.ts b/index.d.ts
@@ -353,7 +353,7 @@ export function compose<TArgs extends any[], R1, R2, R3, R4, R5, R6, R7, TResult
       f2: (a: R1) => R2,
       f1: (...args: TArgs) => R1
   ]
-): (...args: TArgs) => TResult; // fallback overload if number of composed functions greater than 7
+): (...args: TArgs) => TResult;
 export function compose<TArgs extends any[], R1, R2, R3, R4, R5, R6, R7, TResult>(
   f7: (a: R6) => R7,
   f6: (a: R5) => R6,

diff --git a/rambda.js b/rambda.js
@@ -1,4 +1,6 @@
 /// <reference types="./index.d.ts" />
+export * from './src/F.js'
+export * from './src/T.js'
 export * from './src/add.js'
 export * from './src/addIndex.js'
 export * from './src/addIndexRight.js'
@@ -59,7 +61,6 @@ export * from './src/eqBy.js'
 export * from './src/eqProps.js'
 export * from './src/equals.js'
 export * from './src/evolve.js'
-export * from './src/F.js'
 export * from './src/filter.js'
 export * from './src/find.js'
 export * from './src/findIndex.js'
@@ -68,6 +69,7 @@ export * from './src/findLastIndex.js'
 export * from './src/flatten.js'
 export * from './src/flip.js'
 export * from './src/forEach.js'
+export * from './src/forEachObjIndexed.js'
 export * from './src/fromPairs.js'
 export * from './src/groupBy.js'
 export * from './src/groupWith.js'
@@ -145,8 +147,8 @@ export * from './src/prop.js'
 export * from './src/propEq.js'
 export * from './src/propIs.js'
 export * from './src/propOr.js'
-export * from './src/props.js'
 export * from './src/propSatisfies.js'
+export * from './src/props.js'
 export * from './src/range.js'
 export * from './src/reduce.js'
 export * from './src/reject.js'
@@ -166,7 +168,6 @@ export * from './src/startsWith.js'
 export * from './src/subtract.js'
 export * from './src/sum.js'
 export * from './src/symmetricDifference.js'
-export * from './src/T.js'
 export * from './src/tail.js'
 export * from './src/take.js'
 export * from './src/takeLast.js'

diff --git a/src/forEach.js b/src/forEach.js
@@ -1,33 +1,8 @@
 import { isArray } from './_internals/isArray.js'
-import { keys } from './_internals/keys.js'
-
-export function forEachObjIndexedFn(fn, obj){
-  let index = 0
-  const listKeys = keys(obj)
-  const len = listKeys.length
-
-  while (index < len){
-    const key = listKeys[ index ]
-    fn(
-      obj[ key ], key, obj
-    )
-    index++
-  }
-
-  return obj
-}
-
-export function forEachObjIndexed(fn, list){
-  if (arguments.length === 1) return _list => forEachObjIndexed(fn, _list)
-
-  if (list === undefined) return
-
-  return forEachObjIndexedFn(fn, list)
-}
+import { forEachObjIndexedFn } from './forEachObjIndexed.js'
 
 export function forEach(fn, iterable){
   if (arguments.length === 1) return _list => forEach(fn, _list)
-
   if (iterable === undefined) return
 
   if (isArray(iterable)){

diff --git a/src/forEachObjIndexed.js b/src/forEachObjIndexed.js
@@ -0,0 +1,25 @@
+import { keys } from './_internals/keys.js'
+
+export function forEachObjIndexedFn(fn, obj){
+  let index = 0
+  const listKeys = keys(obj)
+  const len = listKeys.length
+
+  while (index < len){
+    const key = listKeys[ index ]
+    fn(
+      obj[ key ], key, obj
+    )
+    index++
+  }
+
+  return obj
+}
+
+export function forEachObjIndexed(fn, list){
+  if (arguments.length === 1) return _list => forEachObjIndexed(fn, _list)
+
+  if (list === undefined) return
+
+  return forEachObjIndexedFn(fn, list)
+}