Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: path() #749

Closed
wants to merge 1 commit into from
Closed

perf: path() #749

wants to merge 1 commit into from

Conversation

romgrk
Copy link
Contributor

@romgrk romgrk commented Oct 29, 2024

If I'm not mistaken, this check is redundant with the one above.

@selfrefactor
Copy link
Owner

I will check if that is the case

@selfrefactor
Copy link
Owner

I am closing this MR as it is needed for

test.only('null is not a valid path', () => {
  expect(path('audio_tracks', {
    a            : 1,
    audio_tracks : null,
  })).toBeUndefined()
})

Ramda passes this test, so Rambda must also.

@romgrk
Copy link
Contributor Author

romgrk commented Nov 5, 2024

That's an annoying behavior from ramda :|

@romgrk romgrk deleted the patch-1 branch November 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants