Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home page exceeds page's dimensions on Chromium-based browsers #470

Merged
merged 4 commits into from
Dec 19, 2023
Merged

Home page exceeds page's dimensions on Chromium-based browsers #470

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
395f3bd
fix: hidden overflowX and min/max width for images
0xjei Dec 11, 2023
66d1387
fix: missing projects page image
0xjei Dec 11, 2023
f6de9cc
refactor: add auto scroll to view to avoid ui bumps
0xjei Dec 12, 2023
071479f
refactor: adapt to chakra ui syntax
0xjei Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/website/src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ export default function Home() {
alt="Midnight whispers image"
src="https://semaphore.cedoor.dev/midnight-whispers.jpg"
objectFit="cover"
w="full"
minWidth="100%"
Copy link
Member

@cedoor cedoor Dec 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could not need this. I've tried it with overflowX: "hidden" only and it works. Could you double-check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean, the w="full"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, * we could not need this.

overflowX: "hidden" could be enough for making it work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, if you remove the parameter minWidth="100%" the images do not extend horizontally and you get something like this

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umh I'm trying it with w="full" and it works

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, maintaining w="full" works since is equivalent to min & max at 100%. Lmk which ones do you prefer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh I'd reduce the number of changes in this PR to the bare minimum.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better for consistency across images, see last commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still another image to update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xjei

maxWidth="100%"
h="full"
/>
</Box>
Expand Down Expand Up @@ -202,7 +203,8 @@ export default function Home() {
alt="Fluttering shadow image"
src="https://semaphore.cedoor.dev/shadow-flutter.jpg"
objectFit="cover"
w="full"
minWidth="100%"
maxWidth="100%"
h="full"
/>
</Box>
Expand Down
3 changes: 2 additions & 1 deletion apps/website/src/app/projects/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ export default function Projects() {
alt="Blue texture image"
src="https://semaphore.cedoor.dev/blue-texture.jpg"
objectFit="cover"
w="full"
minWidth="100%"
maxWidth="100%"
h="full"
/>
</Box>
Expand Down
3 changes: 2 additions & 1 deletion apps/website/src/styles/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ const styles: Styles = {
color: "white"
},
"body, #__next": {
minHeight: "100vh"
minHeight: "100vh",
overflowX: "hidden"
},
"#__next": {
display: "flex",
Expand Down
Loading