Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new article #918

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Add new article #918

merged 2 commits into from
Jan 28, 2025

Conversation

zanastas
Copy link
Contributor

@zanastas zanastas commented Dec 9, 2024

Added new blog post "Getting Started with Semaphore: Building Privacy-Preserving dApps on Ethereum" https://mirror.xyz/0xBE98D44c29D179588b7E717Db8898529e5cD770F/5Xlv1jzwJKfKgP-m257kjivBlUIM_cwTzsmpf9F0Su8

Copy link
Contributor

@aguzmant103 aguzmant103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zanastas do you think you can include the url without the referrer link? I believe it should work the same:

https://mirror.xyz/0xBE98D44c29D179588b7E717Db8898529e5cD770F/5Xlv1jzwJKfKgP-m257kjivBlUIM_cwTzsmpf9F0Su8

Otherwise it looks good! Thanks for contributing with this article

@zanastas
Copy link
Contributor Author

Hello @aguzmant103, sorry for the delay, this article link submitted above (https://mirror.xyz/0xBE98D44c29D179588b7E717Db8898529e5cD770F/5Xlv1jzwJKfKgP-m257kjivBlUIM_cwTzsmpf9F0Su8 ) already does not have referral link (the first part is the author's ID, and the second part direct to the article).

For a comparison, a link with referral link would be this https://mirror.xyz/0xBE98D44c29D179588b7E717Db8898529e5cD770F/5Xlv1jzwJKfKgP-m257kjivBlUIM_cwTzsmpf9F0Su8?referrerAddress=0x6b5153C71D6Bb6E62464987646BF4D2156B47158

Copy link
Member

@vplasencia vplasencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zanastas! Thank you very much for this PR. I just left one comment.

apps/website/src/data/articles.json Outdated Show resolved Hide resolved
remove referral link

Co-authored-by: Vivian Plasencia <[email protected]>
@zanastas
Copy link
Contributor Author

Hey @zanastas! Thank you very much for this PR. I just left one comment.

Ok I have accepted the change- thank you!

@vplasencia vplasencia merged commit e530412 into semaphore-protocol:main Jan 28, 2025
3 checks passed
Copy link

gitpoap-bot bot commented Jan 28, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Semaphore Contributor:

GitPOAP: 2025 Semaphore Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants