Support for dynamic analysis specs with MinAge, MaxAge and Sex columns #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mic-ranges-age-sex
…mic-ranges-age-sex
…mic-ranges-age-sex
…mic-ranges-age-sex
…mic-ranges-age-sex
…mic-ranges-age-sex
|
Waiting eagerly for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Caution
Requires senaite/senaite.core#2467
This Pull Request adds support for dynamic specs with additional columns
MinAge,MaxAgeandSex.Note that
MinAgeis inclusive, whileMaxAgeis exclusive:[MinAge, MaxAge). Therefore, is possible to define consecutive ranges like follows:Besides,
If the value for column
Sexis empty, the range will apply for any individual, regardless of sex. Unless another match is found that is more specific than the current one.If the value for column
MinAgeis empty (or any of the forms0d,0m,0y- or combination of them -), the minimum age won't be considered, butMaxAgeonly.If the value for column
MaxAgeis empty, the maximum age won't be considered, but MinAge` only.Additional columns (e.g. like
Method) are considered as well, as per default core behavior.Current behavior before PR
Dynamic specifications with age and sex are not supported by default
Desired behavior after PR is merged
Dynamic specifications with age and sex are supported by default
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.