Skip to content

Commit

Permalink
fix: Update render feedback rule based on myFeedbackStatus (#260)
Browse files Browse the repository at this point in the history
### Changelog
- Message feedback buttons are displayed if and only if
`message.myFeedbackStatus` is not 'NOT_APPLICABLE'

### Ticket
https://sendbird.atlassian.net/browse/AC-2290

discussion:

https://sendbird.slack.com/archives/C0585965FFA/p1717402133967919?thread_ts=1717121915.460269&cid=C0585965FFA
  • Loading branch information
liamcho authored Jun 7, 2024
1 parent 576298e commit 01dfc75
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
1 change: 0 additions & 1 deletion packages/self-service/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ function App() {
applicationId={appId}
botId={botId}
betaMark={false}
enableEmojiFeedback={false}
enableMention={false}
customUserAgentParam={{ 'chat-ai-widget-deployed': 'True' }}
serviceName={serviceName ?? widgetServiceName.self.default}
Expand Down
2 changes: 1 addition & 1 deletion packages/uikit
Submodule uikit updated 2 files
+1 −1 package.json
+8 −5 yarn.lock
1 change: 1 addition & 0 deletions src/components/CustomMessage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export default function CustomMessage(props: Props) {
const shouldRenderFeedback = () => {
return (
enableEmojiFeedback &&
message.myFeedbackStatus !== 'NOT_APPLICABLE' &&
!isBotWelcomeMessage &&
!(isLastBotMessage && isLastMessageInStreaming(message.data))
);
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3068,9 +3068,9 @@ __metadata:
languageName: unknown
linkType: soft

"@sendbird/chat@npm:^4.12.3":
version: 4.12.6
resolution: "@sendbird/chat@npm:4.12.6"
"@sendbird/chat@npm:^4.12.7":
version: 4.12.7
resolution: "@sendbird/chat@npm:4.12.7"
peerDependencies:
"@react-native-async-storage/async-storage": ^1.17.6
react-native-mmkv: ^2.12.2
Expand All @@ -3079,7 +3079,7 @@ __metadata:
optional: true
react-native-mmkv:
optional: true
checksum: 10c0/35b501357a9c5b3ce49a7faac5c8b8b8d7c921851ea4e0b949a86678caa7eb5a829395a20469eaa0c50c175af9d3a85d034c14f49386953558dfb048a64b340c
checksum: 10c0/c10a306e778ea3196fa6a0668a0d5d85c9e96caeacdb1f3c92a3cf036a089d1b90f07bc524d5f42f656bc548df28be50c1135505729d1d57ebe042c19e8420b4
languageName: node
linkType: hard

Expand Down Expand Up @@ -3123,7 +3123,7 @@ __metadata:
"@rollup/plugin-node-resolve": "npm:^15.2.3"
"@rollup/plugin-replace": "npm:^5.0.4"
"@rollup/plugin-typescript": "npm:^11.1.5"
"@sendbird/chat": "npm:^4.12.3"
"@sendbird/chat": "npm:^4.12.7"
"@sendbird/react-uikit-message-template-view": "npm:0.0.1-alpha.73"
"@sendbird/uikit-tools": "npm:0.0.1-alpha.73"
"@storybook/addon-essentials": "npm:^8.0.9"
Expand Down

0 comments on commit 01dfc75

Please sign in to comment.