-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update render feedback rule based on myFeedbackStatus #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if it is working properly with the patched chat-sdk before requesting a review?
let me test this tomorrow. I need to figure out how to enable/disable feedback in server. It should be done by request at init step. |
You can check the detailed policy for feedback here: https://docs.google.com/document/d/1M06574UQU3NV-fucbP6HCf1oCvxYyBWC_ETOISrvLQ4/edit (it's included in thread) |
@bang9 the fix has been confirmed through testing! |
I have confirmed that it works well in self-service too. |
@bang9 thanks for testing self-servce. When you have time, can you please share how to test self-service?
I will document the SOP for others too! |
I'll approve it once the chat-sdk is updated. |
I will inform you from a fundamental perspective tomorrow. |
@bang9 Please review sendbird/sendbird-uikit-react#1125, thanks! |
@bang9 all good! video1414155140.mp4 |
great, could you update the head of submodule? |
Changelog
message.myFeedbackStatus
is not 'NOT_APPLICABLE'Ticket
https://sendbird.atlassian.net/browse/AC-2290
discussion:
https://sendbird.slack.com/archives/C0585965FFA/p1717402133967919?thread_ts=1717121915.460269&cid=C0585965FFA