Add lock to Pubsub.execute_command to ensure only one connection is created #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 92.40% 92.36% -0.04%
==========================================
Files 119 119
Lines 30727 30743 +16
==========================================
+ Hits 28392 28395 +3
- Misses 2335 2348 +13
☔ View full report in Codecov by Sentry. |
|
is it better patch it upstream? |
it would be best to patch the upstream as well as we can remove this PR once upstream release a new release Also could you please add a test case for this code (ex. lock is already acquired and trying to acquire a connection doesn't return a new connection)? |
zach-iee
reviewed
Sep 27, 2023
|
@dlunch any update? |
|
Sorry, i was on vacation. i'll add test this week |
dlunch
force-pushed
the
fix/connection-leak
branch
from
fa27fe9 to
3fc64f2
Compare
bellatoris
approved these changes
Oct 27, 2023
zach-iee
approved these changes
Oct 27, 2023
dlunch
added a commit
that referenced
this pull request
Oct 27, 2023
…reated (#19) * Add lock to Pubsub.execute_command to ensure only one connection is created * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.