Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for timeout argument in RedisCluster #21

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

zach-iee
Copy link

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

I've forgot to port the change i've implemented to redis-py
https://github.com/sendbird/soda/pull/16439

@zach-iee zach-iee requested a review from bellatoris October 23, 2023 05:55
@zach-iee zach-iee self-assigned this Oct 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1032660) 92.40% compared to head (911a854) 92.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   92.40%   92.36%   -0.04%     
==========================================
  Files         119      119              
  Lines       30727    30727              
==========================================
- Hits        28392    28380      -12     
- Misses       2335     2347      +12     
Files Coverage Δ
redis/cluster.py 90.73% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zach-iee zach-iee requested a review from bellatoris October 23, 2023 06:48
@zach-iee zach-iee merged commit a0ad397 into master Oct 23, 2023
46 checks passed
@zach-iee zach-iee deleted the zach/do_not_filter_timeout branch October 23, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants