Sudhanshu/5009 #5046
Sudhanshu/5009 #5046
Conversation
Signed-off-by: SudhanshuBawane <[email protected]>
Signed-off-by: SudhanshuBawane <[email protected]>
Signed-off-by: SudhanshuBawane <[email protected]>
Signed-off-by: SudhanshuBawane <[email protected]>
Signed-off-by: SudhanshuBawane <[email protected]>
Signed-off-by: SudhanshuBawane <[email protected]>
asset/boltdb_manager.go
Outdated
| @@ -130,6 +134,7 @@ func (b *boltDBAssetManager) Get(ctx context.Context, asset *corev2.Asset) (*Run | |||
| if value != nil { | |||
| // deserialize asset | |||
| if err := json.Unmarshal(value, &localAsset); err == nil { | |||
| logger.Println(err) | |||
There was a problem hiding this comment.
I believe you forgot to clean this up?
asset/expander_test.go
Outdated
| @@ -8,6 +8,39 @@ import ( | |||
| "github.com/sensu/sensu-go/testing/testutil" | |||
| ) | |||
|
|
|||
| //var asset *v2.Asset | |||
There was a problem hiding this comment.
I believe you forgot those comments too?
cli/commands/asset/add.go
Outdated
| @@ -36,6 +36,9 @@ func AddCommand(cli *cli.SensuCli) *cobra.Command { | |||
|
|
|||
| func addCommandExecute(cli *cli.SensuCli) func(cmd *cobra.Command, args []string) error { | |||
| return func(cmd *cobra.Command, args []string) error { | |||
| //sudhanshu/5009 | |||
There was a problem hiding this comment.
Nitpick: No need to have the bug/pr reference here.
| @@ -0,0 +1,28 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
I think you added this file by accident?
| @@ -0,0 +1,7 @@ | |||
| Copyright 2020 Todd Campbell | |||
There was a problem hiding this comment.
I think you added this file by accident?
| @@ -0,0 +1,107 @@ | |||
| [](https://bonsai.sensu.io/assets/sensu/check-cpu-usage) | |||
There was a problem hiding this comment.
I think you added this file by accident?
There was a problem hiding this comment.
I think you added this file by accident?
There was a problem hiding this comment.
I think you added this file by accident?
|
I should have done over this with you but as a rule of thumb you want to provide a description of the PR instead of the ticket number. Also please fill the form which should be provided when you create the PR. You can leave empty the sections that don't apply. You can see #5011 as an example. |
Signed-off-by: Sudhanshu Bawane <[email protected]>
##The change is regarding the git issue 5009 for the incorrect behavior of agent when asset.db used to get deleted.
##This change insured the smooth working of agent and re-download of asset.db without any hassle.
##The change was verified by trying to re-create the bug scenario using same steps and test cases.