slack sdk change #52
Merged
slack sdk change #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
Signed-off-by: manisha kumari <[email protected]>
fguimond
reviewed
Jun 5, 2024
main.go
Outdated
| @@ -5,10 +5,11 @@ import ( | |||
| "os" | |||
| "strings" | |||
|
|
|||
| "github.com/bluele/slack" | |||
| //"github.com/bluele/slack" | |||
There was a problem hiding this comment.
Nitpick: commented out code should be removed :)
fguimond
reviewed
Jun 5, 2024
main.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("Failed to send Slack message: %v", err) | ||
| return fmt.Errorf("Failed to send Slack message: %v ", err) |
There was a problem hiding this comment.
I think you accidentally added an extra white space at the end of the caption.
|
Aside from a couple of small comments it looks good and should be ready to be merged. |
Signed-off-by: manisha kumari <[email protected]>
|
Please publish on bonsai. 🙏🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closed #41
Description
Update slack dependent sdk from "github.com/bluele/slack" to "github.com/slack-go/slack" and its related functions in code
Change verification
Added snippet of message sent to slack :