Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Frontend-Only Slow Performance Story #312

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

cstavitsky
Copy link
Contributor

@cstavitsky cstavitsky commented Nov 1, 2023

Pass frontendSlowdown=true to trigger a frontend-only slowdown on a new /products-fes (fes = frontend slowdown) page.

  • triggers a quick backend products fetch when frontendSlowdown=true is passed, so as to make the http span smaller, and the frontend-only slow span stand out more clearly. See: Add query param to cause frontend-only slowdown #305
  • causes slow render problem when frontendSlowdown=true is passed, which creates the frontend-only slow span. See: Create a span that causes frontend-only performance slowdown #273
  • triggers a performance issue (this should happen, all the criteria are met for uncompressed asset performance issue; however, it can only be tested at scale so we plan to merge this in)

Examples tested in staging

Screenshots of Staging

Screenshot 2023-11-07 at 12 42 48 PM Screenshot 2023-11-07 at 12 41 50 PM

Navigation Transaction for /products-fes

Screenshot 2023-11-07 at 3 40 13 PM

Pageload Transaction for /products-fes

Same as navigation transaction but with browser assets loading and stuff.

Screenshot 2023-11-07 at 4 00 59 PM

Continuing The Frontend-Only Slowdown Story

Screenshot 2023-11-07 at 3 47 42 PM Screenshot 2023-11-07 at 3 49 13 PM

@cstavitsky cstavitsky requested a review from a team as a code owner November 1, 2023 23:10
@cstavitsky cstavitsky marked this pull request as draft November 1, 2023 23:10
@cstavitsky cstavitsky changed the title Add query param for frontend only slowdown Implement Frontend-Only Slowdown Nov 7, 2023
@cstavitsky cstavitsky changed the title Implement Frontend-Only Slowdown Implement Frontend-Only Slow Performance Story Nov 7, 2023
@cstavitsky cstavitsky marked this pull request as ready for review November 8, 2023 00:03
@cstavitsky cstavitsky requested a review from ndmanvar November 8, 2023 00:04
@cstavitsky
Copy link
Contributor Author

@ndmanvar I deployed this to staging so you can check it out.

Can you please test:

  • the new functionality (1. pass ?frontendSlowdown=true on homepage to make Browse Products point to the frontend-only-slowdown route, 2. visit /products-fes route directly with no query param necessary
  • the existing functionality for FE+BE slowdown, to ensure there are no regressions

I already tested, but I definitely want to avoid regressions to our demo data, so please test as well.

@cstavitsky cstavitsky merged commit e7ac9dd into master Nov 9, 2023
1 check passed
@cstavitsky cstavitsky deleted the frontend-only-slowdown-query-param branch November 9, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants